[LAPACK] Add builder #2658
Merged
[LAPACK] Add builder #2658
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giordano
reviewed
Mar 7, 2021
giordano
reviewed
Mar 8, 2021
Co-authored-by: Mosè Giordano <[email protected]>
|
Yes, usually we prefer to keep things separate |
|
@giordano Ok to merge? |
|
Yes, looks good |
|
We need to be ILP64 and have |
Closed
sjkelly
added a commit
to sjkelly/BLISBLAS.jl
that referenced
this pull request
Mar 7, 2024
It appears like all these issues have been resolved: - JuliaPackaging/Yggdrasil#2657 - JuliaPackaging/Yggdrasil#2658 cc @ranocha @ViralBShah
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #2657
The main missing thing here is to make it depend on our own BLAS, ideally through LBT. I'm not quite sure how to make its cmake recipe pick a BLAS - help welcome.