[New Package] Legate #11186
Draft
[New Package] Legate #11186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giordano
reviewed
May 15, 2025
Comment on lines
+11
to
+12
| L/legate/Manifest.toml | ||
| L/legate/Project.toml |
There was a problem hiding this comment.
That sounds a bit specific. Why do you need the environment there? Why not using the one in .ci instead, which is what's actually used here in CI?
giordano
reviewed
May 15, 2025
giordano
reviewed
May 15, 2025
L/legate/build_tarballs.jl
Outdated
|
|
||
| # also some warnings about avx2 instruction set vs x86_64 | ||
| products = [ | ||
| LibraryProduct("liblegate", :liblegate, dont_dlopen = true) # dont_dlopen avoids version `GLIBCXX_3.4.30' not found |
There was a problem hiding this comment.
Not dlopening here means that whatever package uses this will have to manually dlopen the library.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This wraps the legate library from NVIDIA. For now it should work with CUDA 12.2 - 12.8. I still need to get things working for other architectures and expand the MPI ABI.