Skip to content

Revamp tests #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 13, 2020
Merged

Revamp tests #5

merged 2 commits into from
Jul 13, 2020

Conversation

jlumpe
Copy link
Collaborator

@jlumpe jlumpe commented Jul 11, 2020

Changes:

  • Move outer @testset and using statements to runtests.jl(easier to add more outer test sets/include other files in future)
  • Directly compare results against brute force searches
    • Reusable testing functions to do this for multiple trees and queries
  • Test against larger data arrays
  • Test multiple queries per metric
  • Handle ambiguity in find_nearest when there is a tie for the kth-nearest data point
    • Explicit test case for this
  • Test invalid arguments to constructor (empty data set, non-callable metric, no proper method for metric)
  • Clean up code a bit

Currently, the hamming distance @testset fails due to #4.

@jlumpe jlumpe force-pushed the revamp-tests branch 2 times, most recently from 7b9bb67 to 0cf8310 Compare July 11, 2020 23:46
@altre altre merged commit fad8442 into JuliaNeighbors:master Jul 13, 2020
@jlumpe jlumpe deleted the revamp-tests branch July 13, 2020 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants