Fix error in _find_threaded, make sure tests run in thread mode #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @jlumpe, I just gave you write access to the repository. Unfortunately this package didn't make into my day job, so I'm not finding enough time right now. Hope to get back to it in the future. |
|
Thanks @altre, I'll just go ahead and merge the current PRs if that's alright. They're all tested and shouldn't break anything. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forgot to add
skipargument to recursive call in_find_threadedin previous PR. This wasn't caught by the tests because they either weren't running the threaded search or the data set was too small to trigger a new thread to spawn (which was where the error was). Updated tests to use large data sets (at least 10,000, 10x larger than the 1000 required to spawn a new thread in a recursive call) and to explicitly build the tree with boththreaded=trueandthreaded=false.