Tests for complex norms #101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #101 +/- ##
==========================================
+ Coverage 51% 51.42% +0.42%
==========================================
Files 62 62
Lines 2847 2847
==========================================
+ Hits 1452 1464 +12
+ Misses 1395 1383 -12
Continue to review full report at Codecov.
|
|
You are a good programmer. Thank you for the two-step. |
|
Sure. Thanks for maintaining this great package 👍. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry @JeffreySarnoff I missed in my first fix, that the complex norm function also returns the wrong type for 2-norms (namely e.g.
Complex{Double64}, where a real type should be returned). So I made some small tests, just to be sure for next time ...