-
Notifications
You must be signed in to change notification settings - Fork 3
Add copy, lmul! and rmul! methods #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportBase: 97.04% // Head: 97.26% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #8 +/- ##
==========================================
+ Coverage 97.04% 97.26% +0.22%
==========================================
Files 5 5
Lines 169 183 +14
==========================================
+ Hits 164 178 +14
Misses 5 5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
I'm happy to add other method definitions in this PR if you can think of any that you would want. As I mentioned in the description of the PR, the ones I chose to include were dictated by what I needed in another package. |
@andreasnoack Is it okay to merge this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missed this PR. Yes, it looks good to me.
Add a
copy
method forHermitianRFP
. The other two types,TriangularRFP
andCholeskyRFP
, had acopy
method but not Hermitian.Add methods for
lmul!
andrmul!
that amount to an in-place scaling. The matrix argument in the signature is specified asAbstractRFP
. Is this inefficient?Add a method for
BLAS.syrk!
withHermitianRFP
.The choice of methods to define is influenced by what I need for the MixedModels package I will leave this as a draft PR until I finish with incorporating RFP storage in that package.