Skip to content

Comment out @debug statements #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 20, 2025
Merged

Comment out @debug statements #150

merged 1 commit into from
Apr 20, 2025

Conversation

andreasnoack
Copy link
Member

Profiling reveals that there is a lot of overhead from them even at the default logging level. Hopefully that will improve over time. For now, users would have to uncomment these lines before debugging.

As an example

Current master

julia> @btime GenericLinearAlgebra._eigen!(S) setup = (S = LinearAlgebra.SymTridiagonal(ones(100), 0.2*ones(99)));
  505.083 μs (12 allocations: 159.12 KiB)

This PR

julia> @btime GenericLinearAlgebra._eigen!(S) setup = (S = LinearAlgebra.SymTridiagonal(ones(100), 0.2*ones(99)));
  153.222 μs (12 allocations: 159.12 KiB)

Profiling reveals that there is a lot of overhead from them even
at the default logging level. Hopefully that will improve over time.
For now, users would have to uncomment these lines before debugging.
Copy link

codecov bot commented Apr 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.80%. Comparing base (55a38e6) to head (21be7de).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #150      +/-   ##
==========================================
- Coverage   91.94%   91.80%   -0.15%     
==========================================
  Files          10       10              
  Lines        1577     1549      -28     
==========================================
- Hits         1450     1422      -28     
  Misses        127      127              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@andreasnoack andreasnoack merged commit bebae94 into master Apr 20, 2025
7 checks passed
@andreasnoack andreasnoack deleted the an/disabledebug branch April 20, 2025 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant