Avoid abstractly typed field in SymmetricTridiagonalFactorization #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
but comment it out for now
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #148 +/- ##
==========================================
- Coverage 96.18% 96.17% -0.01%
==========================================
Files 11 11
Lines 1651 1649 -2
==========================================
- Hits 1588 1586 -2
Misses 63 63 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Some of the signatures in LinearAlgebra has changed which causes test failures.
andreasnoack
force-pushed
the
an/noabstractsym
branch
from
139b4bd to
1cd6e0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes a bit of overhead in the symmetric eigensolvers.