convert Tarjan algorithms to iterative structure #59143
Merged
+735
−312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that we do not use too much stack space. Conversion implemented by Claude.
adienes
reviewed
Jul 29, 2025
base/staticdata.jl
Outdated
| return 0, minworld, maxworld | ||
|
|
||
| # Return results from the root call | ||
| return (root_result.child_cycle, root_result.result_minworld, root_result.result_maxworld) |
There was a problem hiding this comment.
won't this still be an empty VerifyMethodResultState(0, 0, 0) ? workspace.result_states[1] may have been overwritten but root_result doesn't change
There was a problem hiding this comment.
Thanks for catching that. It used to be mutable and then I changed that without remembering I'd need to re-test. I merged, but happy for post-commit review too if anyone notices any other translations mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that we do not use too much stack space.
Conversion implemented by Claude.