Make type hashing :total
#52427
Merged
Make type hashing :total
#52427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I thought the hash of data types could change between runs |
|
That was fixed on master recently, so we should remove that documentation |
aviatesk
reviewed
Dec 7, 2023
|
I think "run to run" in that documentation refers to different invocations of julia/"sessions of the REPL", not different queries of |
aviatesk
reviewed
Dec 7, 2023
aviatesk
reviewed
Dec 7, 2023
Co-authored-by: Shuhei Kadowaki <[email protected]>
Co-authored-by: Shuhei Kadowaki <[email protected]>
aviatesk
force-pushed
the
type_hash_effects
branch
from
246fae5 to
77bfb46
Compare
|
@vtjnash Do you know if the hashing changes you mention on master were backported to 1.10? Would be nice to backport this as well, if so |
|
This wasn't backported (and it would be a somewhat risky backport imo #52119) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since types can't really be deleted and the hash of a type is already being cached inside of the type object itself, it should be legal to mark the
ccallretrieving that hash as:total, permitting hashing of types to be concretely evaluated.I'm unsure if the test I've added is good as written, or whether this should be done differently.