Skip to content

Precompilation support, consistent speed improvements! #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 24, 2023

Conversation

ashwanirathee
Copy link
Member

Following the path of JuliaImages/ImageFiltering.jl#255 and JuliaImages/ImageQualityIndexes.jl#54 , Use of precompilation and utilization of latest options in precompilation through use of pkgimage has some great effects and improvements all across the board.

For me, initial invocation of

@time @eval read_tags("tmp.jpg"; read_all = true)

improves with latest options

Combination of precompilation and latest options in precompilation
In 1.9.0 dropped from 0.58 seconds to 0.015 seconds, approximately 40x improvements which is impressive.
In 1.8.5 dropped from 0.55 seconds to 0.37 seconds on use of precompilation.

I saw improvements almost all across board in benchmarks that can be found in gist below. One concern though for me is size of compiled caches of ExifViewer even in my basic testing, in 1.8.5 it was 1.92 mb(only .ji file) while in 1.9.0 it was 5.04mb(.ji + .dll file). ExifViewer.jl is a small package with just 2 functions and yet taking a lot of space surprisingly.

More details can be found here: https://gist.github.com/ashwani-rathee/d250abdd0172603448b0e81a96815681

@codecov
Copy link

codecov bot commented Feb 23, 2023

Codecov Report

Base: 92.45% // Head: 93.06% // Increases project coverage by +0.61% 🎉

Coverage data is based on head (2f793a2) compared to base (9283ae7).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #19      +/-   ##
==========================================
+ Coverage   92.45%   93.06%   +0.61%     
==========================================
  Files           4        5       +1     
  Lines         159      173      +14     
==========================================
+ Hits          147      161      +14     
  Misses         12       12              
Impacted Files Coverage Δ
src/ExifViewer.jl 100.00% <ø> (ø)
src/precompile.jl 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants