Bloch_RF_accuracy test reference update #569
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cncastillo
approved these changes
May 19, 2025
The issue is linked correctly. It is important to consider that this pull request solves an issue presented in the conversation of #207 that you mentioned. If that was the remaining problem in the issue, #207 should be considered closed.
NRMSE(raw, mxy_diffeq) = 0.3244598557717778 |
|
Something is off, it should be less than 0.1% |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced the results reference from the Bloch_RF_accuracy test that was hardcoded with the generation of this result using OrdinaryDiffEqTsit5.
This Pull Request is generated from the issue mentioned at #207