-
Notifications
You must be signed in to change notification settings - Fork 23
How to test contributions #553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
I think the instructions are too verbose. The instruction for If the user generates a new function that is not currently tested the Code Coverage will decrease. This will be reported in the same PR. It would be great to add instructions to add tests. Furthermore, if |
I only used ChatGPT to check the redaction, but I wrote it down. most of the KomaMRICore text is directly from its note in the |
Could you please give me an example to understand it and add it to the documentation? |
This was solved in commit 31050a1 |
This is an example on how the code diverse looks |
Created the instructions in this commit 8ac276e |
@Stockless where can i see a preview? |
I have created a local preview with Live Server in VSCode to verify the correct compilation of the documentation. This are some screenshots of the latest corrections implemented 9edc5fa: |
I meant a docs preview. A website I can click, like done in other PRs. |
I understand now. Here is the preview. |
I don't think you completely got my comments, so I put them as a GDocs https://docs.google.com/document/d/1X8Wy81SwumONU4357gz56BNcKM-QLTKVJfP3ew_ly2E/edit?usp=sharing |
Added the section "How to test contributions" in the "How to contribute to Koma" documentation. this PR sovles the issue #552
Here is the preview.