-
Notifications
You must be signed in to change notification settings - Fork 10
[WIP] add submodule for C bindings, library compilation with PackageCompiler #88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #88 +/- ##
==========================================
- Coverage 73.81% 73.15% -0.66%
==========================================
Files 18 19 +1
Lines 1245 1345 +100
==========================================
+ Hits 919 984 +65
- Misses 326 361 +35 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
321f097
to
382b53c
Compare
The CI for Julia 1.9 fails as documenting I couldn't think of a good way of error handling.
I also couldn't find a reasonable way to translate Julia exceptions to C++ exceptions without going through C-bottleneck |
We don't need to support 1.9 I guess, but I hope we can backport JuliaLang/julia#51587 to 1.10. |
Yeah, I would agree we can drop support for 1.9 now, but the LTS release (1.10) we should try to support |
Just report this crashes on OS X with [ Info: PackageCompiler: Executing /Users/graemes/.julia/dev/JetReconstruction/compile/precompile_execution.jl => /var/folders/kq/jgwv_wcj3ll2n6qwj06pp6jr0000gn/T/jl_packagecompiler_0hx01x/jl_dsyOUt
julia(84816,0x1f264cf40) malloc: *** error for object 0x134add910: pointer being freed was not allocated
julia(84816,0x1f264cf40) malloc: *** set a breakpoint in malloc_error_break to debug
[84816] signal 6: Abort trap: 6
in expression starting at /Users/graemes/.julia/dev/JetReconstruction/compile/precompile_execution.jl:33 I'm investigating! |
Thanks for checking. I think that was because the |
Yes, now it works - thanks for the quick fix @m-fila! |
Added compiling with With the nightlies I get a lot of warnings like this. They might be false positives though:
Taking all into account some results
with |
sounds good!
for this, I guess time to retry #84 |
Thankfully SIMD and its deps seem to be working fine with juliac |
I guess makes sense, it's just injecting LLVM IRs |
|
Adding C bindings and ahead of time compilation to shared library with PackageCompiler.jl or juliac
C components have
jetreconstruction_
(orJETRECONSTRUCTION_
) prefixFor now the C API includes only:
jet_reconstruct
exclusive_jets
,inclusive_jets
Vector{T}
field withPtr{T}
andCsize_t
fields for C-facing structs)The C header file has to be written manually and keep in sync with Julia code. Technically the whole
compile
could be a separate julia package possibly eveb living in a separate repo, but I think it'd be harder to keep in sync this wayTo do:
inclusive_jets
andexclusive_jets
PseudoJet
for pp andEEJet
for ee algorithmsJetReconstructionConfig.cmake
juliac
?- [ ] add c-style building (make/CMake)?