-
Notifications
You must be signed in to change notification settings - Fork 10
use SIMD.jl for x86 and naive_findmin
for :aarch64
#151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
after fixing that, on Apple M4, I get:
this looks not bad??!? @graeme-a-stewart Although, there's an unfortuante degredation on 1.12 |
Co-authored-by: Jerry Ling <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #151 +/- ##
==========================================
+ Coverage 75.07% 75.48% +0.40%
==========================================
Files 19 19
Lines 1252 1277 +25
==========================================
+ Hits 940 964 +24
- Misses 312 313 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Nvidia Grace
AMD Ryzen 7 5700G
|
yeah ok so we use the SIMD.jl for x86 and this PR for ARM? |
naive_findmin
naive_findmin
for :aarch64
what happened to CI lol... |
For completeness, with SIMD for x86_64 AMD Ryzen 7 5700G
|
I will test against this PR later |
Would be good to run CI on aarch64 (Linux and/or macOS), no? |
so this is same as nightly, and slower than Julia 1.11 |
Just a test if I understand how to replace
fast_findmin
implementation as in #83