By default use local version of JetReconstruction in examples and docs #142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #142 +/- ##
=======================================
Coverage 73.89% 73.89%
=======================================
Files 18 18
Lines 1249 1249
=======================================
Hits 923 923
Misses 326 326 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
graeme-a-stewart
approved these changes
Mar 27, 2025
There was a problem hiding this comment.
Hi @m-fila - I tested this with 1.9 just to check and indeed, it works just fine. Thanks!
sattwamo
pushed a commit
to sattwamo/JetReconstruction.jl
that referenced
this pull request
Mar 30, 2025
graeme-a-stewart
added a commit
that referenced
this pull request
Apr 1, 2025
* Removed Jet Substructure Structs Using separate structs for calling substructure functions seemed redundant. Removed the structs and incorporated their functionalities into the functions itself. * use local version of JetReconstruction in examples and docs (#142) * Jet utilities (#141) (#144) Add functions to calculate the momentum fraction and the kt scale for jets. - pt_fraction() for transverse momentum fraction - kt_scale() These are implemented generically for both jet types, though may be primary interesting for pp events (PseudoJet). deltar is added as a helper that returns the jet separation in pseudorapidity-phi. This is distinct from deltaR which operates in rapidity-phi space. These are probably not the greatest names, but are not in the public API. deltaR is moved to the new source file, JetUtils.jl. There is a small tidy up of the logic for calculating ϕ where the check for ϕ>2π can never be true. Added functions to convert jets to LorentzVector and LorentzVectorCyl. This required some initial refactoring of jet methods to be general, rather than PseudoJet specific, which will be continued. (cherry picked from commit c7cfa9e) * Rename EEjet to EEJet (#137) * Rename EEjet to EEJet Follow Julia standard capitalisation more closely * Rename source file * Update struct name Co-authored-by: Mateusz Jakub Fila <[email protected]> * Add basic unit tests for jet types This improves test coverage * Fixup a few old struct name references --------- Co-authored-by: Mateusz Jakub Fila <[email protected]> * Modified function signatures Modified the function signatures for `mass_drop`, `soft_drop`, `jet_filtering` and `jet_trimming` and updated documentations. Added `invalid_pseudojet` and `isvalid` and modified `test-substructure.jl`. * Better comparison against invalid_pseudojet Co-authored-by: Mateusz Jakub Fila <[email protected]> * Use invalid from Base; documentation improvements * Add type specifiers to docstrings --------- Co-authored-by: Mateusz Jakub Fila <[email protected]> Co-authored-by: Graeme A Stewart <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One too many times I forgot to
devthe main package and was running with package from JuliaHub and wondering where are my changesI propose to use
[sources]directive so examples docs automatically pick-up local version of JetReconstruction.jl. It's still possible tofreeordevsomewhere else later. This also shouldn't interfere with CI.The
[sources]directive was added in Julia 1.11. For earlier versions this is transparent and not doing anything, so the package should still bedeved manually.Probably in 1.12 some of these could be replaced with
[workspace]to resolve all the dependencies for sub-projects together.