Add jet parents retrieval #121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add parent_jets() accessor, that returns a jet's parents or nothing. Export this method. "Promote" has_parents() to ClusterSequence source file and ensure it works with both jet types. Add tests for parent jet retrieval, in case where a jet has parents and also when it doesn't.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #121 +/- ##
==========================================
+ Coverage 73.49% 73.73% +0.23%
==========================================
Files 18 18
Lines 1249 1245 -4
==========================================
Hits 918 918
+ Misses 331 327 -4 ☔ View full report in Codecov by Sentry. |
m-fila
reviewed
Feb 6, 2025
Ensure that jet and ClusterSequence have the same type Co-authored-by: Mateusz Jakub Fila <[email protected]>
Use the new get_parents() function
m-fila
reviewed
Feb 7, 2025
Normally a jet has either two parents or none (initial particle). However, for a beam merge step there is only one parent, so protect mass_drop and soft_drop by checking both parents are valid.
|
Thanks for the useful review @m-fila ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
parent_jets()accessor, that returns a jet's parents or nothing. Export this method."Promote"Removehas_parentsto ClusterSequence source file and ensure it works with both jet types (or anyFourMomentum).has_parentsas unneededAdd tests for parent jet retrieval, in case where a jet has parents and also when it doesn't.
Closes #100