Skip to content

allow exclusive and inclusive jets to return jet type used in clusterseq #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

m-fila
Copy link
Member

@m-fila m-fila commented Jan 30, 2025

Fixing exclusive_jets and inclusive_jets so they can return either a LorentzVectorCyl or the type used for jets in input ClusterSequence.

Previously it wasn't possible to obtain EEjet from inclusive_jets .
For both inclusive and exclusive it was possible to try converting ClusterSequence{EEjet} to Pseudojet - now requesting wrong type will produce LorentzVectorCyl

Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.61%. Comparing base (164c6d2) to head (dd58e14).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #118      +/-   ##
==========================================
+ Coverage   73.49%   73.61%   +0.11%     
==========================================
  Files          18       18              
  Lines        1249     1247       -2     
==========================================
  Hits          918      918              
+ Misses        331      329       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@graeme-a-stewart graeme-a-stewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @m-fila - this was overlooked when the parametrised version of ClusterSequence was introduced.

@graeme-a-stewart graeme-a-stewart added the enhancement New feature or request label Jan 30, 2025
@graeme-a-stewart graeme-a-stewart merged commit 96bde1b into JuliaHEP:main Jan 30, 2025
9 checks passed
@m-fila m-fila deleted the selection_types branch January 30, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants