Skip to content

Activate the test env with TestEnv.jl #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 29, 2025

Conversation

m-fila
Copy link
Member

@m-fila m-fila commented Jan 29, 2025

This is a follow-up from #114

  • Adding Agua badge in readme and putting aqua tests in a testset
  • Merging back test/Project.toml with Project.toml, and using TestEnv.jl to activate the test environment

TestEnv can be used to programmatically activate a test environment so there is no need to create a separate project for tests.
Running separate files can be done from shell with the main project which I think is quite nice and simple:

julia --project test/test-pp-reconstruction.jl

The cost of this is that the TestEnv should be installed in the default environment, which should be fine since it's small and self-contained, and other packages also suggest using it. Testing with Pkg still works fine without TestEnv

Anyway if TestEnv is too much then I can revert to the current solution with test/Project.toml and propose some changes for it.

@m-fila m-fila added the tests Related to testing the code label Jan 29, 2025
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.61%. Comparing base (164c6d2) to head (48a3437).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #115      +/-   ##
==========================================
+ Coverage   73.49%   73.61%   +0.11%     
==========================================
  Files          18       18              
  Lines        1249     1247       -2     
==========================================
  Hits          918      918              
+ Misses        331      329       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@graeme-a-stewart graeme-a-stewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice! Thanks @m-fila.

@graeme-a-stewart
Copy link
Member

@all-contributors please add @m-fila for infrastructure, tests

@graeme-a-stewart graeme-a-stewart merged commit bba044f into JuliaHEP:main Jan 29, 2025
9 checks passed
Copy link
Contributor

@graeme-a-stewart

I've put up a pull request to add @m-fila! 🎉

@m-fila m-fila deleted the test_env2 branch January 29, 2025 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Related to testing the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants