Move notification to notify
#58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timholy
commented
Jan 4, 2021
| val = observable[] | ||
| for f in listeners(observable) | ||
| if f isa InternalFunction | ||
| f(val) |
There was a problem hiding this comment.
I should point out that this bypass will need to go away (see #50), but I have that queued for a later pull request. (This is the second in a series of 9.)
SimonDanisch
approved these changes
Jan 14, 2021
Previously we had `notify!`, which had the `!` because it called `setindex!`. But notification does not require mutation of the owner. This moves the work of notification from `setindex!` to `notify` and deprecates `notify!`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we had
notify!, which had the!because it calledsetindex!. But notification does not require mutation of the owner.This moves the work of notification from
setindex!tonotifyanddeprecates
notify!.