Fix connect!
#55
Merged
Fix connect!
#55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As a heads-up, I have a whole bunch of other changes queued, but to avoid having to constantly resolve merge conflicts I'll submit them sequentially. I'm not exactly sure how the sequence should relate to released versions; by the time the series is done, I think it would be reasonable to consider a 1.0 release. |
`connect!` did the opposite of what was described in the docstring. The docstring is more consistent with the convention of the modified argument being first, so we go with the docstring and change the code. While technically this is a bugfix, it could trigger StackOverFlow errors, so let's call this a breaking change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
connect!did the opposite of what was described in the docstring.The docstring is more consistent with the convention of the modified
argument being first, so we go with the docstring and change the code.
While technically this is a bugfix, it could trigger StackOverFlow
errors, so let's call this a breaking change.