Skip to content

catch + print errors manually #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 6, 2018
Merged

catch + print errors manually #26

merged 1 commit into from
Nov 6, 2018

Conversation

SimonDanisch
Copy link
Member

Julia does seem to have problems with errors setindex(obs, val) - it might stack overflow or just silently freeze. A try catch and manual error display seems to solve this

@codecov-io
Copy link

codecov-io commented Oct 2, 2018

Codecov Report

Merging #26 into master will decrease coverage by 1.67%.
The diff coverage is 60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #26      +/-   ##
==========================================
- Coverage   98.19%   96.52%   -1.68%     
==========================================
  Files           5        5              
  Lines         111      115       +4     
==========================================
+ Hits          109      111       +2     
- Misses          2        4       +2
Impacted Files Coverage Δ
src/Observables.jl 92.85% <60%> (-3.3%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eab11fc...5bd1dba. Read the comment docs.

@SimonDanisch SimonDanisch merged commit abf3e7c into master Nov 6, 2018
@SimonDanisch SimonDanisch deleted the sd-trycatch branch November 6, 2018 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants