Skip to content

applycoord hotfix #956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 25, 2024
Merged

applycoord hotfix #956

merged 1 commit into from
Jul 25, 2024

Conversation

eliascarv
Copy link
Member

@eliascarv eliascarv commented Jul 25, 2024

The addition of Manifold to types caused problems with the Transducers.tcollect function which crashes the compiler when used with very complex types.
MWE:

julia> using Meshes

julia> using Random; Random.seed!(123);

julia> r = rand(Ring);

julia> gset = GeometrySet([Multi([PolyArea(r)])]);

julia> gset |> Translate(1, 1, 1)

In this PR, I replace the tcollect function with a vector comprehension as a temporary solution.

@juliohm juliohm merged commit 4993bee into master Jul 25, 2024
7 checks passed
@juliohm juliohm deleted the apply-coord-hot-fix branch July 25, 2024 18:17
souma4 pushed a commit to souma4/Meshes.jl that referenced this pull request Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants