Skip to content

Bridge hotfix #955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 25, 2024
Merged

Bridge hotfix #955

merged 2 commits into from
Jul 25, 2024

Conversation

juliohm
Copy link
Member

@juliohm juliohm commented Jul 25, 2024

This hotfix is not ideal, but works for now. We need to brainstorm a better pattern for these fixes with non Cartesian coordinates.

@juliohm juliohm requested a review from eliascarv July 25, 2024 13:40
Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.99%. Comparing base (4c99fab) to head (5aba722).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #955      +/-   ##
==========================================
+ Coverage   88.96%   88.99%   +0.02%     
==========================================
  Files         178      178              
  Lines        5466     5470       +4     
==========================================
+ Hits         4863     4868       +5     
+ Misses        603      602       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juliohm juliohm merged commit 0ccad9d into master Jul 25, 2024
9 checks passed
@juliohm juliohm deleted the bridge-hotfix branch July 25, 2024 14:19
souma4 pushed a commit to souma4/Meshes.jl that referenced this pull request Feb 11, 2025
* Use flat in bridge

* Fix and test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants