Add support for non-Euclidean manifolds #947
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliohm
commented
Jul 22, 2024
juliohm
commented
Jul 22, 2024
juliohm
commented
Jul 22, 2024
juliohm
commented
Jul 23, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #947 +/- ##
==========================================
- Coverage 89.23% 88.90% -0.34%
==========================================
Files 178 178
Lines 5435 5470 +35
==========================================
+ Hits 4850 4863 +13
- Misses 585 607 +22 ☔ View full report in Codecov by Sentry. |
juliohm
commented
Jul 24, 2024
juliohm
commented
Jul 24, 2024
juliohm
commented
Jul 24, 2024
juliohm
commented
Jul 24, 2024
eliascarv
approved these changes
Jul 24, 2024
souma4
pushed a commit
to souma4/Meshes.jl
that referenced
this pull request
Feb 11, 2025
* Add manifolds.jl * Cleanup imports * Add M paramters to all primitives * Flip C<>M in primitives.jl * Add M to polytopes.jl * Add M to multigeoms.jl * Add M to domains.jl * Additional fixes * More fixes * Fix meshes * Delay addition of deps * Add constructors for 'Point' * Apply suggestions * Update Primitives * Update Polytopes * Update src/primitives/paraboloidsurface.jl Co-authored-by: Júlio Hoffimann <[email protected]> * Apply suggestions * Update 'axis' function * Update Domains * Add partial order for Ellipsoid manifold * Improve docstring for Box * Fix tests * Apply suggestions * Update tests * Update aliases * Add more type parameter restrictions * Update MeshesMakieExt * Apply suggestions * Apply suggestions * Apply suggestions * Apply suggestions * Update 'vizsubdom!' fallback * Update exports * Fix viz * Fix docs * Fix tests * Fix viz --------- Co-authored-by: Elias Carvalho <[email protected]> Co-authored-by: Elias Carvalho <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #116