Skip to content

Refactor the implementation of the rand function #941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jul 17, 2024
Merged

Refactor the implementation of the rand function #941

merged 11 commits into from
Jul 17, 2024

Conversation

eliascarv
Copy link
Member

No description provided.

Copy link

codecov bot commented Jul 17, 2024

Codecov Report

Attention: Patch coverage is 96.29630% with 2 lines in your changes missing coverage. Please review.

Project coverage is 89.12%. Comparing base (6fc96bc) to head (3938828).

Files Patch % Lines
src/rand.jl 96.29% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #941      +/-   ##
==========================================
- Coverage   89.13%   89.12%   -0.01%     
==========================================
  Files         177      178       +1     
  Lines        5440     5427      -13     
==========================================
- Hits         4849     4837      -12     
+ Misses        591      590       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eliascarv eliascarv marked this pull request as ready for review July 17, 2024 12:49
@eliascarv eliascarv requested a review from juliohm July 17, 2024 12:49
@juliohm juliohm merged commit df8349e into master Jul 17, 2024
8 of 9 checks passed
@juliohm juliohm deleted the rand branch July 17, 2024 13:44
souma4 pushed a commit to souma4/Meshes.jl that referenced this pull request Feb 11, 2025
* Refactor the implementation of the 'rand' function

* Add docstring

* Add tests

* Apply suggestions

* Fix tests

* Update documentation

* Fix tests

* Add documentation

* Apply suggestions

* Update docs/src/rand.md

* Add more tests

---------

Co-authored-by: Júlio Hoffimann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants