Skip to content

Viz boxes with globe manifold using MaxLengthDiscretization #1087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

eliascarv
Copy link
Member

@eliascarv eliascarv commented Sep 26, 2024

The default maximum length I chose is 100 km.

Example:

b = Box(Point(LatLon(0, 170)), Point(LatLon(45, 90)))
viz(b)

master:

julia> viz(b)
ERROR: StackOverflowError:

PR:
image

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 87.37%. Comparing base (07473e9) to head (ceba6c7).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
ext/geometryset.jl 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1087      +/-   ##
==========================================
- Coverage   87.50%   87.37%   -0.14%     
==========================================
  Files         188      188              
  Lines        5947     5956       +9     
==========================================
  Hits         5204     5204              
- Misses        743      752       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eliascarv eliascarv requested a review from juliohm September 26, 2024 13:44
@eliascarv eliascarv merged commit e1a22c0 into master Sep 26, 2024
14 of 16 checks passed
@eliascarv eliascarv deleted the viz-box branch September 26, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant