Skip to content

Generalize dispatch to OrthoRegularGrid #1079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Sep 20, 2024
Merged

Generalize dispatch to OrthoRegularGrid #1079

merged 9 commits into from
Sep 20, 2024

Conversation

eliascarv
Copy link
Member

No description provided.

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.54%. Comparing base (10b15de) to head (72b4504).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1079   +/-   ##
=======================================
  Coverage   87.54%   87.54%           
=======================================
  Files         188      188           
  Lines        5935     5935           
=======================================
  Hits         5196     5196           
  Misses        739      739           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

eliascarv and others added 3 commits September 20, 2024 13:20
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@eliascarv eliascarv marked this pull request as ready for review September 20, 2024 16:26
@eliascarv eliascarv requested a review from juliohm September 20, 2024 16:26
@eliascarv eliascarv changed the title Update definition of grid methods Update definition of CartesianGrid methods Sep 20, 2024
eliascarv and others added 2 commits September 20, 2024 13:41
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@juliohm juliohm changed the title Update definition of CartesianGrid methods Generalize dispatch to OrthoRegularGrid Sep 20, 2024
@juliohm juliohm merged commit ba58b2a into master Sep 20, 2024
16 checks passed
@juliohm juliohm deleted the grid-methods branch September 20, 2024 17:05
souma4 pushed a commit to souma4/Meshes.jl that referenced this pull request Feb 11, 2025
* Update definition of grid methods

* Apply suggestions

* Apply suggestions

* Apply suggestions from code review

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update src/domains/meshes/cartesiangrid.jl

* Apply suggestions

* Format

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Apply suggestions

* Format

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Júlio Hoffimann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants