Skip to content

Convert pointer address spaces when calling rtlib functions. #704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2025
Merged

Convert pointer address spaces when calling rtlib functions. #704

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions src/rtlib.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,10 +49,16 @@ function LLVM.call!(builder, rt::Runtime.RuntimeMethodInstance, args=LLVM.Value[
end
for (i,arg) in enumerate(args)
if value_type(arg) != parameters(ft)[i]
if (value_type(arg) isa LLVM.PointerType) &&
args[i] = if (value_type(arg) isa LLVM.PointerType) &&
(parameters(ft)[i] isa LLVM.IntegerType)
# Julia pointers are passed as integers
args[i] = ptrtoint!(builder, args[i], parameters(ft)[i])
# pointers are passed as integers on Julia 1.11 and earlier
ptrtoint!(builder, args[i], parameters(ft)[i])
elseif value_type(arg) isa LLVM.PointerType &&
parameters(ft)[i] isa LLVM.PointerType &&
addrspace(value_type(arg)) != addrspace(parameters(ft)[i])
# runtime functions are always in the default address space,
# while arguments may come from globals in other address spaces.
addrspacecast!(builder, args[i], parameters(ft)[i])
else
error("Don't know how to convert ", arg, " argument to ", parameters(ft)[i])
end
Expand Down
Loading