Skip to content

Cache the runtime library in memory. #699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 4, 2025
Merged

Cache the runtime library in memory. #699

merged 2 commits into from
Jun 4, 2025

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented Jun 4, 2025

Helps with #698

Copy link

codecov bot commented Jun 4, 2025

Codecov Report

Attention: Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.

Project coverage is 72.12%. Comparing base (046ceba) to head (b1f8912).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
src/spirv.jl 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #699      +/-   ##
==========================================
- Coverage   73.80%   72.12%   -1.69%     
==========================================
  Files          24       24              
  Lines        3486     3483       -3     
==========================================
- Hits         2573     2512      -61     
- Misses        913      971      +58     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

github-actions bot commented Jun 4, 2025

Your PR requires formatting changes to meet the project's style guidelines.
Please consider running Runic (git runic master) to apply these changes.

Click here to view the suggested changes.
diff --git a/src/spirv.jl b/src/spirv.jl
index 2afd4f6..147ddb2 100644
--- a/src/spirv.jl
+++ b/src/spirv.jl
@@ -169,11 +169,15 @@ end
     optimized = tempname(cleanup=false) * ".spv"
     if job.config.target.optimize
         try
-            run(```$(SPIRV_Tools_jll.spirv_opt()) -O --skip-validation
-                                                  $translated -o $optimized```)
+            run(
+                ```$(SPIRV_Tools_jll.spirv_opt()) -O --skip-validation
+                $translated -o $optimized```
+            )
         catch
-            error("""Failed to optimize generated SPIR-V.
-                     If you think this is a bug, please file an issue and attach $(input) and $(translated).""")
+            error(
+                """Failed to optimize generated SPIR-V.
+                If you think this is a bug, please file an issue and attach $(input) and $(translated)."""
+            )
         end
     else
         cp(translated, optimized)

@maleadt maleadt merged commit 64c4c0c into master Jun 4, 2025
22 checks passed
@maleadt maleadt deleted the tb/cache_runtime branch June 4, 2025 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant