Adding the complete architecture for search benchmarking #2740
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mortenpi
reviewed
Jun 12, 2025
| search_index_data = load_real_search_index() | ||
|
|
||
| # Create a Node.js script that recreates the search logic from search.js | ||
| wrapper_js = """ |
There was a problem hiding this comment.
This one is pretty big. Might be better to have this as a .js file that we read(..., String) in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this closes #2417, this still has a lot of work to do, I am just putting it out there so everybody can see and give their suggestions on it. this is nowhere completed. I am going to work on it, maybe end up changing a substantial amount but right now it is just a proof of concept. would love to get some feedback on it. what do you think could be improved and what do you guys have in mind???
Thank you