Improve how the at-quietly logs are handled in the tests #1882
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create a more unform pattern for loading the module to make sure that we do not accudentally load it several times as the tests runs, resetting the output log file, if that is enabled.
And also print the log ID in the test output if the logs are enabled, so that it would be easy to find the corresponding log.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change loading of TestUtilities
Create a more uniform pattern for loading the module to make sure that we
do not accidentally load it several times as the tests runs, resetting
the output log file, if that is enabled.
Store at-quietly logs in separate files
And also print the log ID in the test output if the logs are enabled, so
that it would be easy to find the corresponding log.