Respect generated function invariants #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated functions cannot call any function which might have a method added after the generated function is defined. This means we need to hoist such functions outside the generator, either by calling them beforehand (as we do with axistrait), or ensuring that all methods are defined before the generator (axisdim). This fixes #161 (test failures with precompiled-modules=no).
c42f
force-pushed
the
cjf/generated-function-fixes
branch
from
47005f0 to
8fe78ec
Compare
|
Thanks Tim! |
Closed
This was referenced Aug 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generated functions cannot call any function which might have a method
added after the generated function is defined. This means we need to
hoist such functions outside the generator, either by calling them
beforehand (as we do with axistrait), or ensuring that all methods are
defined before the generator (axisdim).
I belive this fixes #161 (test failures with precompiled-modules=no).
TODO
axistrait()out of the generated function here.