Skip to content

🚀 Feature: Use npm modules for validation #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jasonkarns opened this issue May 26, 2015 · 4 comments
Open

🚀 Feature: Use npm modules for validation #44

jasonkarns opened this issue May 26, 2015 · 4 comments
Labels
status: accepting prs Please, send a pull request to resolve this! 🙏 type: feature New enhancement or request 🚀

Comments

@jasonkarns
Copy link

The version field probably ought to be validated using the semver module, and the license field probably ought to be validated using the spdx module. Both of these are used by normalize-package-data which in turn is used by npm itself when parsing the package.json.

Other parsing/validation rules (for the npm spec, at least) ought to be brought in line with the normalization rules from normalize-package-data

@JoshuaKGoldberg
Copy link
Owner

This would be great: the closer this package gets to the npm spec, the better!

Per #78 I'm still ramping up on this project, so I don't want to take on any big changes anytime soon. Marking this one as status: blocked until the existing slate of smaller fixes & feature request come through.

@JoshuaKGoldberg JoshuaKGoldberg added type: feature New enhancement or request 🚀 status: blocked Waiting for something else to be resolved 🙅 labels Mar 28, 2024
@JoshuaKGoldberg JoshuaKGoldberg changed the title Use npm modules for validation 🚀 Feature: Use npm modules for validation Mar 28, 2024
@michaelfaith michaelfaith added status: accepting prs Please, send a pull request to resolve this! 🙏 and removed status: blocked Waiting for something else to be resolved 🙅 labels May 11, 2025
@michaelfaith
Copy link
Collaborator

This should be included in the new modular validateVersion and validateLicense functions

@JoshuaKGoldberg
Copy link
Owner

@all-contributors please add @jasonkarns for ideas.

🤖 Beep boop! This comment was added automatically by all-contributors-auto-action.
Not all contributions can be detected from Git & GitHub alone. Please comment any missing contribution types this bot missed.
...and of course, thank you for contributing! 💙

Copy link
Contributor

@JoshuaKGoldberg

I've put up a pull request to add @jasonkarns! 🎉

JoshuaKGoldberg pushed a commit that referenced this issue May 12, 2025
Adds @jasonkarns as a contributor for ideas.

This was requested by JoshuaKGoldberg [in this
comment](#44 (comment))

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: accepting prs Please, send a pull request to resolve this! 🙏 type: feature New enhancement or request 🚀
Projects
None yet
Development

No branches or pull requests

3 participants