Skip to content

fix: support jsr package version specifiers #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 29, 2025
Merged

fix: support jsr package version specifiers #211

merged 1 commit into from
Apr 29, 2025

Conversation

azat-io
Copy link
Contributor

@azat-io azat-io commented Apr 26, 2025 •
edited by JoshuaKGoldberg
Loading

PR Checklist

Overview

Support jsr:* packages.

@azat-io azat-io mentioned this pull request Apr 26, 2025
Closed
3 tasks
michaelfaith
michaelfaith approved these changes Apr 26, 2025
View reviewed changes
Copy link
Collaborator

@michaelfaith michaelfaith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Thanks for the quick work!

@michaelfaith
Copy link
Collaborator

michaelfaith commented Apr 26, 2025 •
edited
Loading

@JoshuaKGoldberg thoughts on why something related to CTA would be failing here? This is blocking the merge.

screenshot of build failure

@michaelfaith
Copy link
Collaborator

@all-contributors please add @azat-io for code

@allcontributors allcontributors bot mentioned this pull request Apr 26, 2025
Merged
@allcontributors AllContributors
Copy link
Contributor

@michaelfaith

I've put up a pull request to add @azat-io! 🎉

@michaelfaith
Copy link
Collaborator

michaelfaith commented Apr 26, 2025 •
edited
Loading

The compliance build appears to be broken too (unrelated to this change)
Error: Resource not accessible by integration

@michaelfaith
Copy link
Collaborator

michaelfaith commented Apr 26, 2025 •
edited
Loading

This token must not have been added to the repo: https://github.com/JoshuaKGoldberg/package-json-validator/blob/main/.github/workflows/cta.yml#L11C11-L11C45 (this isn't something I'm able to see)

This PR should be good to merge once that's ironed out. I have no ability to override it 🫤

michaelfaith pushed a commit that referenced this pull request Apr 26, 2025
@allcontributors
docs: add azat-io as a contributor for code (#212)
ec03d00 
Adds @azat-io as a contributor for code.

This was requested by michaelfaith [in this
comment](#211 (comment))

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
@michaelfaith michaelfaith enabled auto-merge (squash) April 26, 2025 20:12
@michaelfaith
Copy link
Collaborator

Curiously these build steps didn't fail on #212

JoshuaKGoldberg
JoshuaKGoldberg approved these changes Apr 29, 2025
View reviewed changes
Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! 🙌

@JoshuaKGoldberg
Copy link
Owner

I'll take a look at the permissions / token issues. Compliance in particular is passing on other repos and I wouldn't have expected to fail here.

@JoshuaKGoldberg JoshuaKGoldberg merged commit 77e8c7e into JoshuaKGoldberg:main Apr 29, 2025
14 of 20 checks passed
@github-actions GitHub Actions
Copy link

🎉 This is included in version v0.10.2 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

@michaelfaith michaelfaith michaelfaith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@azat-io @michaelfaith @JoshuaKGoldberg