-
Notifications
You must be signed in to change notification settings - Fork 28
🚀 Feature: Accept jsr: package version specifiers #1019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Seems like a reasonable request. Thanks for raising it. As far as where the change would need to be made, the line you pointed to is actually not what's responsible for identifying violations. That regex is just regexing the output from We'd certainly welcome the contribution! |
@all-contributors please add @csjewell for ideas.
|
I've put up a pull request to add @csjewell! 🎉 |
|
JoshuaKGoldberg/package-json-validator@77e8c7e
Adds @csjewell as a contributor for ideas. This was requested by JoshuaKGoldberg [in this comment](#1019 (comment)) --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Feature Request Checklist
main
branch of the repository.Overview
In pnpm 10.9.0 - specifically, their fix for pnpm/pnpm#8941 - they now accept
jsr:
as a package specifier, like so: (from https://github.com/csjewell/fedi-any-page/blob/dev/packages/re-pliers/package.json#L53-L60)However, I get errors like this when I use this plugin in my eslint configuration (and yes, I'm showing only one example of three package.json files in my repository that are affected by this right now)
I DO understand that they translate this to standard syntax before publishing it to npm. I'd just want this to not throw the error in this case. [I can work around it right now by disabling the rule, but it feels like cutting off the foot at the ankle in order to deal with an infected toe to me.]
It appears that it might be fixable by a one-line change in the rule - at https://github.com/JoshuaKGoldberg/eslint-plugin-package-json/blob/main/src/rules/valid-package-definition.ts#L10 - to me, I just don't have time to create a formal PR at the moment! I MIGHT be able to this weekend if you'd like me to.
Additional Info
No response
The text was updated successfully, but these errors were encountered: