-
Notifications
You must be signed in to change notification settings - Fork 28
feat(require-keywords): add require-keywords rule #884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(require-keywords): add require-keywords rule #884
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #884 +/- ##
=======================================
Coverage 98.77% 98.77%
=======================================
Files 21 21
Lines 1220 1221 +1
Branches 142 142
=======================================
+ Hits 1205 1206 +1
Misses 15 15 ☔ View full report in Codecov by Sentry. |
@michaelfaith @JoshuaKGoldberg Should we add some keywords for this repo? e.g |
It probably wouldn't hurt, but I'm also not sure that it would help any, since those are all components of the package name already. I'd be ok with adding those. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks!
🎉 This is included in version v0.25.0 🎉 The release is available on: Cheers! 📦🚀 |
I think it is helpful like this repo https://github.com/vuejs/eslint-plugin-vue/blob/master/package.json#L31 |
Helpful in what respect? Keywords are used by |
No, you are right. I check the npm docs. This field helps to search package. It is just a suggestion and we can ignore it. |
PR Checklist
status: accepting prs
Overview
Add
require-keywords
rule