Skip to content

🚀 Feature: Bring in a require-author rule #795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 tasks done
JoshuaKGoldberg opened this issue Feb 1, 2025 · 1 comment · Fixed by #851
Closed
3 tasks done

🚀 Feature: Bring in a require-author rule #795

JoshuaKGoldberg opened this issue Feb 1, 2025 · 1 comment · Fixed by #851
Assignees
@michaelfaith
Labels
status: accepting prs Please, send a pull request to resolve this! 🙏 type: feature New enhancement or request 🚀

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

Following #42 -> #51: we've resolved to create a standalone require-author rule. It should enforce that the field exists in the package.json file.

Additional Info

💖
@JoshuaKGoldberg JoshuaKGoldberg added status: accepting prs Please, send a pull request to resolve this! 🙏 type: feature New enhancement or request 🚀 labels Feb 1, 2025
@michaelfaith michaelfaith mentioned this issue Feb 1, 2025
Open
@michaelfaith michaelfaith self-assigned this Feb 1, 2025
@michaelfaith michaelfaith mentioned this issue Feb 2, 2025
Merged
3 tasks
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Feb 3, 2025
Open
michaelfaith added a commit that referenced this issue Feb 3, 2025
@michaelfaith
feat(require-author): add new require-author rule (#851)
cde68da 
<!-- 👋 Hi, thanks for sending a PR to eslint-plugin-package-json! 💖.
Please fill out all fields below and make sure each item is true and [x]
checked.
Otherwise we may not be able to review your PR. -->

## PR Checklist

-   [x] Addresses an existing open issue: fixes #795 
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/eslint-plugin-package-json/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/eslint-plugin-package-json/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

This change adds the first or our new `require-` rules, and creates some
foundational plumbing to make it super easy to add new require rules.
I've only done author in this PR. Assuming this all looks good, we can
quickly knock all the rest of the require rules in one shot.
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 3, 2025

🎉 This is included in version v0.22.0 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michaelfaith michaelfaith

Labels
status: accepting prs Please, send a pull request to resolve this! 🙏 type: feature New enhancement or request 🚀
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(require-author): add new require-author rule JoshuaKGoldberg/eslint-plugin-package-json
2 participants
@JoshuaKGoldberg @michaelfaith