-
Notifications
You must be signed in to change notification settings - Fork 4
Support native google-java-format executables #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
## [1.1.0-beta.1](v1.0.3...v1.1.0-beta.1) (2024-02-18) ### Features * add support for native executable ([4805f80](4805f80)), closes [#17](#17)
## [1.1.0-beta.1](v1.0.3...v1.1.0-beta.1) (2024-02-18) ### Features * add support for native executable ([4805f80](4805f80)), closes [#17](#17)
## [1.1.0-beta.1](v1.0.3...v1.1.0-beta.1) (2024-02-18) ### Features * add support for native executable ([4805f80](4805f80)), closes [#17](#17)
🎉 This issue has been resolved in version 1.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
@vorburger I have verified the native binary is executed correctly in windows and wsl. can you verify it on mac? |
Thanks for implementing this so fast! I have just verified it on Linux and the DL works great - it would only need #20 to "just work out of the box". For Mac the binary should be OK, because I know that a work colleague of mine (@cushon) has tested and fixed it, but I think it may need the same missing I've posted about how I'm happy to have enabled this:
"Formatting completed in 45ms." instead of 473ms previously... That x10 is actually noticeable on Ctrl-S Save a *.java, even on a fast computer - very cool! |
In google/google-java-format#1045 I'm working on making "native" (non
java -jar google-java-format*.jar
) binaries available. If that's accepted, those should start to appear on https://github.com/google/google-java-format/releases in the future.It will initially be for Linux only; perhaps Mac and Windows (will be contributed by others) later.
It would be very cool if this VSC extension could check if it runs on a platform for which a native binary is available, and download and invoke that! (Once it's available for download, of course.)
The text was updated successfully, but these errors were encountered: