Skip to content

Feat/2206 claim streaming payments #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

davecreaser
Copy link
Contributor

@davecreaser davecreaser commented May 7, 2024

CDapp counterpart: JoinColony/colonyCDapp#2323

  • Create a handler for streaming payment claimed.
  • Update the DB with the latest claim when a streaming payment is claimed.

@davecreaser davecreaser self-assigned this May 7, 2024
@davecreaser davecreaser marked this pull request as ready for review May 7, 2024 15:10
Copy link
Collaborator

@jakubcolony jakubcolony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good apart from one small comment 👍

@davecreaser davecreaser requested a review from jakubcolony May 8, 2024 08:40
Copy link
Collaborator

@jakubcolony jakubcolony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, smashing work!

Copy link
Contributor

@iamsamgibbs iamsamgibbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Reviewed with CDapp#2323

@davecreaser davecreaser force-pushed the feat/2206-claim-streaming-payments branch from 3bfe48f to 7ecee0f Compare May 9, 2024 15:15
@davecreaser davecreaser merged commit f209e19 into feat/streaming-payments May 9, 2024
1 check passed
@davecreaser davecreaser deleted the feat/2206-claim-streaming-payments branch May 9, 2024 15:54
jakubcolony pushed a commit that referenced this pull request May 23, 2024
jakubcolony pushed a commit that referenced this pull request Jun 4, 2024
jakubcolony pushed a commit that referenced this pull request Jun 25, 2024
jakubcolony pushed a commit that referenced this pull request Aug 29, 2024
jakubcolony pushed a commit that referenced this pull request Oct 1, 2024
jakubcolony pushed a commit that referenced this pull request Oct 17, 2024
jakubcolony pushed a commit that referenced this pull request Nov 6, 2024
jakubcolony pushed a commit that referenced this pull request Jan 16, 2025
jakubcolony pushed a commit that referenced this pull request Jan 26, 2025
jakubcolony pushed a commit that referenced this pull request Feb 6, 2025
jakubcolony pushed a commit that referenced this pull request Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants