Skip to content

SparkNLP 1131 - Introducing Florance-2 #14585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

prabod
Copy link
Contributor

@prabod prabod commented May 26, 2025

Description

This PR introduce Florence 2 model family to SprakNLP

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Code improvements with no or little impact
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING page.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@prabod prabod requested a review from DevinTDHa May 26, 2025 11:30
@prabod prabod changed the title SparkNLP 1131 - Implementing Florance-2 SparkNLP 1131 - Introducing Florance-2 May 26, 2025
@coveralls
Copy link

Pull Request Test Coverage Report for Build 15252839065

Details

  • 0 of 199 (0.0%) changed or added relevant lines in 4 files are covered.
  • 50 unchanged lines in 33 files lost coverage.
  • Overall coverage decreased (-0.6%) to 52.115%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/scala/com/johnsnowlabs/nlp/annotators/tokenizer/bpe/BpeTokenizer.scala 0 2 0.0%
src/main/scala/com/johnsnowlabs/nlp/pretrained/ResourceDownloader.scala 0 2 0.0%
src/main/scala/com/johnsnowlabs/nlp/annotators/tokenizer/bpe/Florence2Tokenizer.scala 0 24 0.0%
src/main/scala/com/johnsnowlabs/nlp/annotators/cv/Florence2Transformer.scala 0 171 0.0%
Files with Coverage Reduction New Missed Lines %
src/main/scala/com/johnsnowlabs/nlp/annotators/cv/util/io/ImageIOUtils.scala 1 54.22%
src/main/scala/com/johnsnowlabs/nlp/annotators/cv/ViTForImageClassification.scala 1 32.11%
src/main/scala/com/johnsnowlabs/nlp/annotators/er/AhoCorasickAutomaton.scala 1 96.74%
src/main/scala/com/johnsnowlabs/nlp/annotators/ner/dl/LoadsContrib.scala 1 11.54%
src/main/scala/com/johnsnowlabs/nlp/annotators/ner/dl/NerDLModel.scala 1 58.23%
src/main/scala/com/johnsnowlabs/nlp/annotators/ner/NerTagsEncoding.scala 1 70.45%
src/main/scala/com/johnsnowlabs/nlp/annotators/parser/dep/GreedyTransition/DependencyMaker.scala 1 81.01%
src/main/scala/com/johnsnowlabs/nlp/annotators/parser/dep/Tagger.scala 1 47.54%
src/main/scala/com/johnsnowlabs/nlp/annotators/pos/perceptron/PerceptronApproachDistributed.scala 1 82.89%
src/main/scala/com/johnsnowlabs/nlp/annotators/sentence_detector_dl/SentenceDetectorDLApproach.scala 1 86.71%
Totals Coverage Status
Change from base Build 15207655495: -0.6%
Covered Lines: 9931
Relevant Lines: 19056

💛 - Coveralls

Copy link
Member

@DevinTDHa DevinTDHa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot!

@DevinTDHa DevinTDHa merged commit 12764d3 into release/602-release-candidate May 26, 2025
4 of 6 checks passed
@DevinTDHa DevinTDHa mentioned this pull request May 26, 2025
10 tasks
DevinTDHa pushed a commit that referenced this pull request May 28, 2025
* Florence2 Scala API

* preprocessing and postprocessing for images

* test images

* python API and tests

* notebooks and docs

* changed postprocessing and added tests for all the tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants