Skip to content

Sparknlp 1060 implement phi 3.5 vision #14444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

prabod
Copy link
Contributor

@prabod prabod commented Oct 29, 2024

This PR Integrates Phi3 Vision family models into SparkNLP

Screenshots (if appropriate):

Types of changes

  • Code improvements with no or little impact
  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING page.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@prabod prabod requested a review from maziyarpanahi November 8, 2024 06:25
@prabod prabod force-pushed the SPARKNLP-1060-Implement-Phi-3.5-Vision branch from 30364b2 to f7e6d2d Compare November 8, 2024 06:36
@prabod prabod marked this pull request as ready for review November 8, 2024 06:36
@prabod prabod self-assigned this Feb 12, 2025
Signed-off-by: Prabod Rathnayaka <[email protected]>
Signed-off-by: Prabod Rathnayaka <[email protected]>
Signed-off-by: Prabod Rathnayaka <[email protected]>
Signed-off-by: Prabod Rathnayaka <[email protected]>
Signed-off-by: Prabod Rathnayaka <[email protected]>
Signed-off-by: Prabod Rathnayaka <[email protected]>
Signed-off-by: Prabod Rathnayaka <[email protected]>
@prabod prabod force-pushed the SPARKNLP-1060-Implement-Phi-3.5-Vision branch from f7e6d2d to 5040468 Compare February 12, 2025 23:51
@prabod prabod added new-feature Introducing a new feature DON'T MERGE Do not merge this PR labels Feb 13, 2025
@maziyarpanahi maziyarpanahi changed the base branch from master to release/600-release-candidate March 16, 2025 11:43
@maziyarpanahi maziyarpanahi merged commit 44fb92a into release/600-release-candidate Mar 16, 2025
4 checks passed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 13883000244

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 292 (0.0%) changed or added relevant lines in 5 files are covered.
  • 20 unchanged lines in 14 files lost coverage.
  • Overall coverage decreased (-1.0%) to 59.034%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/scala/com/johnsnowlabs/nlp/pretrained/ResourceDownloader.scala 0 1 0.0%
src/main/scala/com/johnsnowlabs/nlp/annotators/tokenizer/bpe/BpeTokenizer.scala 0 2 0.0%
src/main/scala/com/johnsnowlabs/nlp/annotators/tokenizer/bpe/Phi3VisionTokenizer.scala 0 31 0.0%
src/main/scala/com/johnsnowlabs/nlp/annotators/cv/util/transform/Phi3vUtils.scala 0 122 0.0%
src/main/scala/com/johnsnowlabs/nlp/annotators/cv/Phi3Vision.scala 0 136 0.0%
Files with Coverage Reduction New Missed Lines %
src/main/scala/com/johnsnowlabs/nlp/annotators/er/EntityRulerApproach.scala 1 95.11%
src/main/scala/com/johnsnowlabs/nlp/annotators/er/EntityRulerModel.scala 1 90.4%
src/main/scala/com/johnsnowlabs/nlp/annotators/ner/crf/FeatureGenerator.scala 1 93.85%
src/main/scala/com/johnsnowlabs/nlp/annotators/sda/pragmatic/SentimentDetectorModel.scala 1 97.22%
src/main/scala/com/johnsnowlabs/nlp/annotators/spell/symmetric/SymmetricDeleteApproach.scala 1 90.32%
src/main/scala/com/johnsnowlabs/nlp/annotators/tokenizer/bpe/BpeTokenizer.scala 1 76.69%
src/main/scala/com/johnsnowlabs/nlp/annotators/ws/WordSegmenterModel.scala 1 74.63%
src/main/scala/com/johnsnowlabs/nlp/pretrained/ResourceDownloader.scala 1 39.81%
src/main/scala/com/johnsnowlabs/nlp/pretrained/S3ResourceDownloader.scala 1 52.59%
src/main/scala/com/johnsnowlabs/nlp/util/io/OutputHelper.scala 1 56.41%
Totals Coverage Status
Change from base Build 13882990181: -1.0%
Covered Lines: 9413
Relevant Lines: 15945

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DON'T MERGE Do not merge this PR new-feature Introducing a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants