Skip to content

Add WineBootTimeout to Config #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 7, 2024
Merged

Add WineBootTimeout to Config #13

merged 3 commits into from
Dec 7, 2024

Conversation

ImKringle
Copy link
Contributor

image

@JoeJoeTV
Copy link
Owner

JoeJoeTV commented Dec 7, 2024

This looks good to me, but did you try this at least once as a sanity check?
Also, could you add the config option to the example config in the README file?

@ImKringle
Copy link
Contributor Author

I can't replicate the issue myself, but I can confirm it at least boots correctly with the default 30 value - Pinged nbdy in that Discord to see if they can make sure it resolves their issue; as they have finals atm it may be a moment before they confirm it worked

Added WineBootTimeout to README though!

@JoeJoeTV
Copy link
Owner

JoeJoeTV commented Dec 7, 2024

Alright, thanks for the contribution!
Since it starts with the default value and the change is relatively simple, I will merge this and if there are further problem, I will fix them separately.

@JoeJoeTV JoeJoeTV merged commit 92cf27e into JoeJoeTV:master Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ImKringle @JoeJoeTV