Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Update vcpkg-tool to 2025-04-01 (#44751)" (#44815) #1931

Merged
merged 1 commit into from
Apr 4, 2025

Conversation

Jimmy-Hu
Copy link
Owner

@Jimmy-Hu Jimmy-Hu commented Apr 4, 2025

Merge from microsoft-master

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Jimmy-Hu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request reverts a previous update to the vcpkg-tool. Specifically, it reverts the changes introduced in PR microsoft#44751, which updated the vcpkg-tool to the 2025-04-01 release. This PR effectively rolls back the vcpkg-tool to the 2025-03-22 release by modifying the scripts/vcpkg-tool-metadata.txt file to use the older release tag and corresponding SHA values for macOS, MUSLC, GLIBC (including ARM64), and the tool source.

Highlights

  • Reversion: This pull request reverts the vcpkg-tool to the 2025-03-22 release.
  • Metadata Update: The scripts/vcpkg-tool-metadata.txt file is modified to reflect the older vcpkg-tool release, including the release tag and SHA values.

Changelog

  • scripts/vcpkg-tool-metadata.txt
    • Reverted VCPKG_TOOL_RELEASE_TAG from 2025-04-01 to 2025-03-22.
    • Reverted VCPKG_MACOS_SHA from e4197519f04803d698e124c45e6ea3a945908f29654affa500a75e788fe5c2789722ecfbf4540276b1249f57c340bf68ab352fa0ae348d900d176a4c3e75fbb5 to 9732c176969116aa934613cca72d032b0373a2ceb340d9f13b787b0a6c086020f65625d3d3b691ff864983406e437ff26881bf5751e5dbd544aa94a8cf15cfed.
    • Reverted VCPKG_MUSLC_SHA from 5b3b7722116b083070b367bc594bc179e4295d41aa82d3a813656786896c58e791a60293d725f5a96356b0ece1512fe56ef608d3296bb3dab8052929201bcd0d to 269904f06f8e851833381f5876e9fe9f3eac89ff6d60eaa87ef7e4a018df8773703335ad0927cbab7f60a3ff1706167087ccb53b6f646750645920ea00b5f8b3.
    • Reverted VCPKG_GLIBC_SHA from bebfe729eb11494774cf5b7431db96b0d70ea24c7855f25e48e25efd1a21a393f63ffb07d91d35fbda9001eaab64fb012adfee224a5512c2fc64bffe21c1c370 to 671dec56b1387698e4188404f67f651078af9c15b6eb6fb83ec17e745eefea30592e9edde77b033c719376eccdc275a2020b877b2f1afcdf9d07b0ccb9522005.
    • Reverted VCPKG_GLIBC_ARM64_SHA from fb49f630790572000535aded10aa47550a32cc4c6dcf205ebf702a39e33eb0fb4a7214c1d98ae665b505719ac4e15769b672c980579c0af56d26433bf890f70e to b02d03cfa4c2c40b81c7ccc0c0d7c90f0b07313b3d86abc6580744d6aeb34fa9e7630059ba470fa430d49935757c36a9bd6be00e82ff5e7abcb8404fcba3cf3e.
    • Reverted VCPKG_TOOL_SOURCE_SHA from b586eb5fe50f3b8384ef0285a8d06e8a5b327d49881d3794a0591bb8d6e0ecc622bf3c4d31c11a5a6534396d8d4afef43d9b4d2922766fe40b3263d1685e2b8a to bd964a2a23a00e4c3ce7f7842e0bf200baf40ffd231e5309a41f92e6622d81a08f2f8ad3513685b0cf3a95485105eb37588fe568b710d492184043b540b00e82.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.


A version once new,
Now old, we bid adieu.
Reverting back now,
To what worked somehow,
Until the next view.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request reverts the vcpkg-tool to an older version. The changes involve updating the vcpkg-tool-metadata.txt file with the older release tag and corresponding SHA values. The script update-vcpkg-tool-metadata.ps1 is used to update this file. Overall, the changes seem straightforward.

Merge Readiness

The pull request appears to correctly revert the vcpkg-tool to the specified older version. The changes are limited to updating metadata and SHA values, which seems appropriate for a revert. Given the nature of the change, and that there are no critical or high severity issues, I would recommend that the pull request be merged after the medium severity issue is addressed. I am unable to directly approve the pull request, and users should have others review and approve this code before merging.

Comment on lines +1 to +6
VCPKG_TOOL_RELEASE_TAG=2025-03-22
VCPKG_MACOS_SHA=9732c176969116aa934613cca72d032b0373a2ceb340d9f13b787b0a6c086020f65625d3d3b691ff864983406e437ff26881bf5751e5dbd544aa94a8cf15cfed
VCPKG_MUSLC_SHA=269904f06f8e851833381f5876e9fe9f3eac89ff6d60eaa87ef7e4a018df8773703335ad0927cbab7f60a3ff1706167087ccb53b6f646750645920ea00b5f8b3
VCPKG_GLIBC_SHA=671dec56b1387698e4188404f67f651078af9c15b6eb6fb83ec17e745eefea30592e9edde77b033c719376eccdc275a2020b877b2f1afcdf9d07b0ccb9522005
VCPKG_GLIBC_ARM64_SHA=b02d03cfa4c2c40b81c7ccc0c0d7c90f0b07313b3d86abc6580744d6aeb34fa9e7630059ba470fa430d49935757c36a9bd6be00e82ff5e7abcb8404fcba3cf3e
VCPKG_TOOL_SOURCE_SHA=bd964a2a23a00e4c3ce7f7842e0bf200baf40ffd231e5309a41f92e6622d81a08f2f8ad3513685b0cf3a95485105eb37588fe568b710d492184043b540b00e82

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

It's important to verify that the SHA values for the older version are correct and match the expected values. Consider adding a comment or documentation link that explains how these SHA values are generated and verified to ensure the integrity of the tool.

@Jimmy-Hu Jimmy-Hu merged commit 6a75256 into Jimmy-Hu:master Apr 4, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants