Implement PyStubType for either::Either
#207
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
termoshtt
added a commit
that referenced
this pull request
May 31, 2025
Minor revise for #207 Summary by Copilot ------------------- This pull request introduces support for the `either` crate in the `pyo3-stub-gen` project, enabling the use of `either::Either` types in Python stub generation. It also includes minor fixes to existing test cases for improved clarity and correctness. ### Integration of the `either` crate: * [`Cargo.toml`](diffhunk://#diff-2e9d962a08321605940b5a657135052fbcef87b5e360662bb527c96d9a615542R22): Added `either` as a dependency in the workspace and included it as an optional feature in `pyo3-stub-gen`. The default features now include `either`. [[1]](diffhunk://#diff-2e9d962a08321605940b5a657135052fbcef87b5e360662bb527c96d9a615542R22) [[2]](diffhunk://#diff-d2fe0506288d6d1bb990e8185c26e0cdf07ee85787eb78c2bb3d60b70bf88eb0R21) [[3]](diffhunk://#diff-d2fe0506288d6d1bb990e8185c26e0cdf07ee85787eb78c2bb3d60b70bf88eb0L33-R36) * [`pyo3-stub-gen/src/stub_type.rs`](diffhunk://#diff-bec31605b52ecbf7a424c6bcc8dfcf155d211d25316e27ba0945b49284470ae8R8-R10): Added a new module `either` gated behind the `either` feature flag. * [`pyo3-stub-gen/src/stub_type/either.rs`](diffhunk://#diff-5d12c671f041e17061b398055bb9cb24b0360e7af721e1985f863a49b0e446dbR1-R44): Implemented support for `either::Either<L, R>` in stub generation by defining `type_input` and `type_output` methods that map `Either` to Python's `typing.Union`. ### Test case fixes: * [`pyo3-stub-gen/src/util.rs`](diffhunk://#diff-1c01740ca518ff53dff74391ba7e3427fba3221cc3c19de143bcf2568f253e87L114-R116): Updated test cases to pass string literals directly instead of references, improving readability and correctness. --------- Co-authored-by: YuantianDing <[email protected]>
|
Merged via #212 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding stubs for pyo3 support for
either::Either.