Remove dependency to derive crate #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
termoshtt
force-pushed
the
remove-derive-depenency
branch
from
1d1bb96 to
1a6ec38
Compare
termoshtt
added a commit
that referenced
this pull request
Aug 2, 2024
Reverts #15 with modified Cargo.toml setting. https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#the-role-of-the-version-key > Note: [crates.io](https://crates.io/) does not allow packages to be published with dependencies on code published outside of [crates.io](https://crates.io/) itself ([dev-dependencies](https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#development-dependencies) are ignored). So the problem is `dev-dependency.pyo3-stub-gen` in `pyo3-stub-gen-derive/Cargo.toml` specifies version `0.1.0`, which did not exists on crates.io. This version specification is not needed, and removed in this PR. Then, we do not have cyclic dependency. We can release `pyo3-stub-gen-derive` first, and then `pyo3-stub-gen`.
Scyrc
pushed a commit
to Scyrc/pyo3-stub-gen
that referenced
this pull request
May 8, 2025
In order to publish the `pyo3-stub-gen` crate to crates.io, `pyo3-stub-gen-derive` must be exists in crates.io even if it is optional dependency.
Scyrc
pushed a commit
to Scyrc/pyo3-stub-gen
that referenced
this pull request
May 8, 2025
Reverts Jij-Inc#15 with modified Cargo.toml setting. https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#the-role-of-the-version-key > Note: [crates.io](https://crates.io/) does not allow packages to be published with dependencies on code published outside of [crates.io](https://crates.io/) itself ([dev-dependencies](https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#development-dependencies) are ignored). So the problem is `dev-dependency.pyo3-stub-gen` in `pyo3-stub-gen-derive/Cargo.toml` specifies version `0.1.0`, which did not exists on crates.io. This version specification is not needed, and removed in this PR. Then, we do not have cyclic dependency. We can release `pyo3-stub-gen-derive` first, and then `pyo3-stub-gen`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to publish the
pyo3-stub-gencrate to crates.io,pyo3-stub-gen-derivemust be exists in crates.io even if it is optional dependency.