Skip to content

Skip parsing contents of YAML chameleon nodes #943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 4, 2018
Merged

Skip parsing contents of YAML chameleon nodes #943

merged 4 commits into from
Dec 4, 2018

Conversation

citizenmatt
Copy link
Member

@citizenmatt citizenmatt commented Dec 3, 2018 •
edited
Loading

  • Introduce new document body chameleon node. Much easier to skip contents than block mapping chameleon node. Also, doesn't require any parsing to identify the node (block mapping chameleon node requires parsing to identify)
  • Skip parsing (and discarding) contents when creating a chameleon node. Now just iterate skipped tokens

@citizenmatt
Skip parsing contents of chameleon node
4a38a9d 
Also introduces new document body chameleon node
@citizenmatt citizenmatt added this to the Rider 2018.3 milestone Dec 3, 2018
@citizenmatt citizenmatt self-assigned this Dec 3, 2018
@citizenmatt citizenmatt changed the title [WIP] More YAML performance improvements Skip parsing when creating chameleon nodes Dec 4, 2018
@citizenmatt citizenmatt changed the title Skip parsing when creating chameleon nodes Skip parsing contents of YAML chameleon nodes Dec 4, 2018
@citizenmatt citizenmatt merged commit 90c7fef into 183 Dec 4, 2018
@citizenmatt citizenmatt deleted the feature/yaml-performance branch December 4, 2018 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krasnotsvetov krasnotsvetov Awaiting requested review from krasnotsvetov

Assignees

@citizenmatt citizenmatt

Labels
yaml
Projects
None yet
Milestone
Rider 2018.3
Development

Successfully merging this pull request may close these issues.
1 participant
@citizenmatt