Quick fix for NonAlloc API #784
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…name. Handle multiply declarations. Add more tests.
citizenmatt
requested changes
Sep 17, 2018
| else | ||
| { | ||
| newName = originName + "NonAlloc"; | ||
| } |
There was a problem hiding this comment.
Move this section below the check for type, or we'll be doing this for every method invocation in the project.
| var table = type.GetSymbolTable(expression.PsiModule).Filter( | ||
| new AccessRightsFilter(new DefaultAccessContext(expression)), | ||
| new ExactNameFilter(newName), | ||
| new PredicateFilter(t => MatchSignatureAllocToNonAlloc(method, t.GetDeclaredElement() as IMethod))); |
There was a problem hiding this comment.
Is this heuristic good enough to capture all of the methods we need? Can we rely on naming and parameter size +1? Would it be easier to just have a map of allocating to non-allocating methods?
citizenmatt
requested changes
Sep 19, 2018
citizenmatt
approved these changes
Sep 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functions like SphereCast, RaycastAll, CapsuleCast e.t.c has NonAlloc version, analyzer generates warnings when user uses this functions. In some cases, where we can improve user code without unexpected affect quickfix is provided.