Skip to content

Minor fixes #2289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 7, 2022
Merged

Minor fixes #2289

merged 7 commits into from
Mar 7, 2022

Conversation

citizenmatt
Copy link
Member

This PR fixes a couple of issues:

  • Stop adding duplicate GUID based references to .asmdef files (RIDER-75001)
  • Add naive formatting when adding references in .asmdef file, by simply copying the leading whitespace of the preceding reference
  • Simplify IsValid for UnityExternalPsiSourceFile. This is called very frequently, and can have a noticeable impact for very large projects
  • Fix incorrect redundant FormerlySerializedAs attribute warning when applied to the backing field of a property

Will be called a huge amount of times for very large projects, so make as lightweight as possible
@citizenmatt citizenmatt added this to the Rider 2022.1 milestone Mar 4, 2022
@citizenmatt citizenmatt self-assigned this Mar 4, 2022
@citizenmatt citizenmatt merged commit d7c3697 into net221 Mar 7, 2022
@citizenmatt citizenmatt deleted the net221-mte-fixes branch March 7, 2022 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants