Skip to content

Internalization + multiple small fixes #2280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Feb 18, 2022
Merged

Internalization + multiple small fixes #2280

merged 13 commits into from
Feb 18, 2022

Conversation

van800
Copy link
Member

@van800 van800 commented Feb 17, 2022 •
edited
Loading

  1. dot-prefixed folder would get a disabled “icon” as the tilda folder
  2. fix for tooltip for ignored pattern. Specifically, before it was showing similar tooltip for files and folders.
  3. fix for tooltip for Hidden Assets - it would be also shown for files.
  4. fix for MetaFileTracker. Meta files would not get created for HiddenAssets. (But would still be created for children of folder, which is HiddenAsset). More info on Hidden Assets here
  5. rename Show Hidden Folders into Show Folders Ending With '~'
    image

@van800 van800 self-assigned this Feb 17, 2022
@van800 van800 added the WIP Work in progress. Do not merge! label Feb 17, 2022
@van800 van800 requested a review from citizenmatt February 17, 2022 16:54
citizenmatt
citizenmatt requested changes Feb 17, 2022
View reviewed changes
@van800 van800 removed the WIP Work in progress. Do not merge! label Feb 18, 2022
@van800 van800 requested a review from citizenmatt February 18, 2022 10:28
@van800 van800 changed the title Internationalization + fix tooltips for assets, which are out of AssetDatabase Internationalization + multiple small fixes Feb 18, 2022
@van800 van800 changed the title Internationalization + multiple small fixes Internalization + multiple small fixes Feb 18, 2022
citizenmatt
citizenmatt approved these changes Feb 18, 2022
View reviewed changes
Copy link
Member

@citizenmatt citizenmatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@van800 van800 added this to the Rider 2022.1 milestone Feb 18, 2022
@van800 van800 merged commit 9325e60 into net221 Feb 18, 2022
@van800 van800 deleted the net221-internalize branch February 18, 2022 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@citizenmatt citizenmatt citizenmatt approved these changes

Assignees

@van800 van800

Labels
None yet
Projects
None yet
Milestone
Rider 2022.1
Development

Successfully merging this pull request may close these issues.
2 participants
@van800 @citizenmatt